Open
Conversation
thuyanduong
reviewed
Sep 29, 2020
Member
thuyanduong
left a comment
thuyanduong
left a comment
There was a problem hiding this comment.
Hey Gracey!
You were on the right track. The purpose of this Practice Lab was to look at someone else's project and suggest improvements to it! You correctly fixed the grammar in their first sentence in README.md. Also, you improved their code by adding semicolons to helloworld.js, which is a JavaScript best practice.
Other suggestions you could have proposed:
- The rest of
README.mdhas some grammatical mistakes, incorrect spelling, or incorrect capitalization. - The first function in
helloworld.jsis incorrect becauseconsole.printis not a method, butconsole.logis. - The second function in
helloworld.jsis incorrect because you need to have{and}in order to correctly interpolate a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was difficult doing this, I got confuse and gave up. But in the next try am sure I'll understand and get it.